Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datasets): Take mode argument into account when saving dataset #805

Merged
merged 26 commits into from
Aug 22, 2024
Merged

fix(datasets): Take mode argument into account when saving dataset #805

merged 26 commits into from
Aug 22, 2024

Commits on Aug 7, 2024

  1. Take mode argument into account when saving dataset 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    3fba245 View commit details
    Browse the repository at this point in the history

  2. Fix test 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    ed881fe View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. Merge branch 'main' into fix/handle-mode-arg-correctly

    @merelcht
    merelcht authored Aug 12, 2024
    Configuration menu
    Copy the full SHA
    49017f6 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. Move mode to default save args 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    28d173f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'fix/handle-mode-arg-correctly' of https://github.com/ke… 

    …dro-org/kedro-plugins into fix/handle-mode-arg-correctly
    @merelcht
    merelcht committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    e1c59e8 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Revert changes to add mode to save args and add as fs arg default ins… 

    …tead

Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    e71b810 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix/handle-mode-arg-correctly

    @merelcht
    merelcht authored Aug 14, 2024
    Configuration menu
    Copy the full SHA
    eef2651 View commit details
    Browse the repository at this point in the history

  3. Fix lint 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    079b0a3 View commit details
    Browse the repository at this point in the history

  4. Separate fs save and load args again 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    1026380 View commit details
    Browse the repository at this point in the history

  5. Add tests for coverage 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    0725a96 View commit details
    Browse the repository at this point in the history

  6. Try simplify init 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    c7ba314 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Remove writing to buffer and use save_args both in saving and conversion 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    9edd0f9 View commit details
    Browse the repository at this point in the history

  2. Fix tests 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    5905ff6 View commit details
    Browse the repository at this point in the history

  3. Revert back to using fs_args to pass mode argument 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    0de251d View commit details
    Browse the repository at this point in the history

  4. Use fs_args to pass mode for all pandas based datasets 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    3238997 View commit details
    Browse the repository at this point in the history

  5. Make other datasets use fs_args for handling mode as well 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    ef11faa View commit details
    Browse the repository at this point in the history

  6. Refactor and make all datasets consistent 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    97e49a2 View commit details
    Browse the repository at this point in the history

  7. Fix message dataset 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    46aef8d View commit details
    Browse the repository at this point in the history

  8. Fix tests 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    2aa49a8 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Merge branch 'main' into fix/handle-mode-arg-correctly

    @merelcht
    merelcht authored Aug 21, 2024
    Configuration menu
    Copy the full SHA
    86fe86f View commit details
    Browse the repository at this point in the history

  2. Clean up 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    9e7c363 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'fix/handle-mode-arg-correctly' of https://github.com/ke… 

    …dro-org/kedro-plugins into fix/handle-mode-arg-correctly
    @merelcht
    merelcht committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    ea4556e View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into fix/handle-mode-arg-correctly

    @merelcht
    merelcht authored Aug 21, 2024
    Configuration menu
    Copy the full SHA
    8f084de View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. Merge branch 'main' into fix/handle-mode-arg-correctly

    @merelcht
    merelcht authored Aug 22, 2024
    Configuration menu
    Copy the full SHA
    e6825a7 View commit details
    Browse the repository at this point in the history

  2. Update release notes 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    0fb3dac View commit details
    Browse the repository at this point in the history

  3. Merge branch 'fix/handle-mode-arg-correctly' of https://github.com/ke… 

    …dro-org/kedro-plugins into fix/handle-mode-arg-correctly
    @merelcht
    merelcht committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    806d8f4 View commit details
    Browse the repository at this point in the history