Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datasets): Bump delta-spark version #814

Merged
merged 2 commits into from
Aug 22, 2024
Merged

fix(datasets): Bump delta-spark version #814

merged 2 commits into from
Aug 22, 2024

Conversation

rwpurvis
Copy link
Contributor

Description

Further loosen up the spark requirement after #780

Development notes

  • Updated 1 line in config
  • Side node, the pre-commit config seems to need adjusting as it was reformatting much of the pyproject.toml file, I had to override it.

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes not needed
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes not needed

fix(datasets): bump delta-spark version
748c353 
Signed-off-by: Richard Purvis <richard.purvis@quantumblack.com>
@rwpurvis rwpurvis changed the title Bump delta-spark version fix(datasets): Bump delta-spark version Aug 22, 2024
@rwpurvis rwpurvis mentioned this pull request Aug 22, 2024
Closed
DimedS
DimedS approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@DimedS DimedS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @rwpurvis !

astrojuanlu
astrojuanlu approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass 👍🏼 Thanks @rwpurvis !

@astrojuanlu astrojuanlu merged commit 5ce4eab into kedro-org:main Aug 22, 2024
14 checks passed
@rwpurvis rwpurvis deleted the fix/delta-spark-requirement branch August 22, 2024 18:44
merelcht pushed a commit to galenseilis/kedro-plugins that referenced this pull request Aug 27, 2024
@rwpurvis @merelcht
fix(datasets): Bump delta-spark version (kedro-org#814)
7fe2302 
fix(datasets): bump delta-spark version

Signed-off-by: Richard Purvis <richard.purvis@quantumblack.com>
Co-authored-by: Richard Purvis <richard.purvis@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astrojuanlu astrojuanlu astrojuanlu approved these changes

@DimedS DimedS DimedS approved these changes

@noklam noklam Awaiting requested review from noklam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rwpurvis @astrojuanlu @DimedS