Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datasets)!: expose load and save publicly #829

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

deepyaman
Copy link
Member

@deepyaman deepyaman commented Sep 10, 2024

Description

Take advantage of the ability to define public load and save methods.

Also resolves #793

Development notes

This is not compatible with Kedro before 0.19.7.

If Kedro-Datasets required kedro>=0.18 or something before this, I'd be more concerned about bumping the lower bound; right now, it's just a minor bump.

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes

@deepyaman deepyaman marked this pull request as ready for review September 10, 2024 05:09
@deepyaman deepyaman enabled auto-merge (squash) September 10, 2024 12:58
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman deepyaman force-pushed the feat/datasets/expose-load-and-save-publicly branch from d0bd026 to 02b271d Compare September 10, 2024 13:08
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman deepyaman force-pushed the feat/datasets/expose-load-and-save-publicly branch from 02b271d to b6a34a8 Compare September 10, 2024 19:58
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest kedro load and save breaks mypy on datasets
2 participants