Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datasets): Use put() and get() instead of copy in TensorFlowModelDataset's _save and _load methods. #844

Merged
merged 4 commits into from
Sep 26, 2024
Merged

fix(datasets): Use put() and get() instead of copy in TensorFlowModelDataset's _save and _load methods. #844

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5e35f95
fix(datasets): Use `put()` and `get()` instead of `copy` in `TensorFl…
gitgud5000 Sep 22, 2024
578623a
Merge branch 'main' into main
merelcht Sep 25, 2024
3ea21b6
chore: Added comments of changes in `RELEASE.md`
gitgud5000 Sep 25, 2024
85964c4
Merge branch 'main' into main
ankatiyar Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions kedro-datasets/kedro_datasets/tensorflow/tensorflow_model_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ def _load(self) -> tf.keras.Model:
# We assume .keras
path = str(PurePath(tempdir) / TEMPORARY_KERAS_FILE) # noqa: PLW2901

self._fs.copy(load_path, path)
self._fs.get(load_path, path)

# Pass the local temporary directory/file path to keras.load_model
device_name = self._load_args.pop("tf_device", None)
Expand All @@ -169,7 +169,7 @@ def _save(self, data: tf.keras.Model) -> None:

# Use fsspec to take from local tempfile directory/file and
# put in ArbitraryFileSystem
self._fs.copy(path, save_path)
self._fs.put(path, save_path)

def _exists(self) -> bool:
try:
Expand Down