Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create spaceflights-pandas-viz starter #152

Merged
merged 5 commits into from
Oct 6, 2023
Merged

Conversation

merelcht
Copy link
Member

@merelcht merelcht commented Oct 3, 2023

Motivation and Context

Subtask of kedro-org/kedro#2838

Regular Spaceflights with Kedro-Viz features enabled:

  • Matplotlib
  • Ploty
  • Experiment Tracking

The readme's will need to be reviewed in Update all starter docs/READMEs #3111

How has this been tested?

Created a project locally using: kedro new --starter=/Users/merel_theisen/Projects/kedro-starters/spaceflights-pandas-viz/ and did kedro run

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Assigned myself to the PR
  • Added tests to cover my changes

Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@merelcht merelcht changed the title Create spaceflights-viz starter Create spaceflights-pandas-viz starter Oct 3, 2023
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@merelcht merelcht marked this pull request as ready for review October 4, 2023 09:02
@merelcht merelcht self-assigned this Oct 4, 2023
@merelcht merelcht linked an issue Oct 4, 2023 that may be closed by this pull request
Copy link
Contributor

@SajidAlamQB SajidAlamQB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested manually, LGTM! 🚀

Scenario: Lint spaceflights-pyspark starter
Given I have prepared a config file
And I have run a non-interactive kedro new with the starter spaceflights-pyspark
And I have installed the Kedro project's dependencies
When I lint the project
Then I should get a successful exit code

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@merelcht merelcht merged commit 0c56523 into main Oct 6, 2023
18 checks passed
@merelcht merelcht deleted the create-spaceflights-viz branch October 6, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create new spaceflights-pandas-viz starter
3 participants