Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add credentials.yml placeholder files to all spaceflights projects #174

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

merelcht
Copy link
Member

Motivation and Context

While working on kedro-org/kedro#3220 I noticed that the new spaceflights projects don't have the placeholder credentials.yml file. I'm guessing these were not committed when I created the projects because they are ignored in .gitignore. The original spaceflights-pandas project contains a credentials.yml so I'm adding it to the other projects for consistency.

How has this been tested?

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Assigned myself to the PR
  • Added tests to cover my changes

Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Copy link
Contributor

@SajidAlamQB SajidAlamQB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

We'll have to update the add-ons tests on kedro to account for extra file.

@merelcht merelcht merged commit ed01b27 into main Oct 31, 2023
18 checks passed
@merelcht merelcht deleted the add-credential-files branch October 31, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants