Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add add_ons to pyproject.toml in spaceflight starters #175

Merged
merged 10 commits into from
Nov 1, 2023
Merged

Add add_ons to pyproject.toml in spaceflight starters #175

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a8aaec7
Add add_ons to pyproject.toml in spaceflight starters
merelcht Oct 31, 2023
a399560
Add add_ons to cookiecutter.json for pandas spaceflights
merelcht Oct 31, 2023
fdf4860
minor edit
merelcht Oct 31, 2023
2f2c6a8
Update default value syntax for add_ons
merelcht Oct 31, 2023
4b91284
Merge branch 'main' into add-ons-in-pyproject-toml
merelcht Oct 31, 2023
e02d928
Apply suggestions from code review
merelcht Nov 1, 2023
743233f
Merge branch 'main' into add-ons-in-pyproject-toml
merelcht Nov 1, 2023
0fce20f
Update spaceflights-pandas-viz/{{ cookiecutter.repo_name }}/pyproject…
merelcht Nov 1, 2023
0edf771
Apply suggestions from code review
merelcht Nov 1, 2023
bc36e9b
Apply suggestions from code review
merelcht Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spaceflights-pandas-viz/cookiecutter.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
"repo_name": "{{ cookiecutter.project_name.strip().replace(' ', '-').replace('_', '-').lower() }}",
"python_package": "{{ cookiecutter.project_name.strip().replace(' ', '_').replace('-', '_').lower() }}",
"kedro_version": "{{ cookiecutter.kedro_version }}",
"add_ons" : "none"
"add_ons": "['none']"
merelcht marked this conversation as resolved.
Show resolved Hide resolved
}
1 change: 1 addition & 0 deletions spaceflights-pandas-viz/{{ cookiecutter.repo_name }}/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ namespaces = false
package_name = "{{ cookiecutter.python_package }}"
project_name = "{{ cookiecutter.project_name }}"
kedro_init_version = "{{ cookiecutter.kedro_version }}"
add_ons = {{ cookiecutter.add_ons | string | replace("\'", "\"") }}
merelcht marked this conversation as resolved.
Show resolved Hide resolved

[tool.pytest.ini_options]
addopts = """
Expand Down
3 changes: 2 additions & 1 deletion spaceflights-pandas/cookiecutter.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"project_name": "Spaceflights Pandas",
"repo_name": "{{ cookiecutter.project_name.strip().replace(' ', '-').replace('_', '-').lower() }}",
"python_package": "{{ cookiecutter.project_name.strip().replace(' ', '_').replace('-', '_').lower() }}",
"kedro_version": "{{ cookiecutter.kedro_version }}"
"kedro_version": "{{ cookiecutter.kedro_version }}",
"add_ons": "['none']"
merelcht marked this conversation as resolved.
Show resolved Hide resolved
}
1 change: 1 addition & 0 deletions spaceflights-pandas/{{ cookiecutter.repo_name }}/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ namespaces = false
package_name = "{{ cookiecutter.python_package }}"
project_name = "{{ cookiecutter.project_name }}"
kedro_init_version = "{{ cookiecutter.kedro_version }}"
add_ons = {{ cookiecutter.add_ons | string | replace("\'", "\"") }}
merelcht marked this conversation as resolved.
Show resolved Hide resolved

[tool.pytest.ini_options]
addopts = """
Expand Down
2 changes: 1 addition & 1 deletion spaceflights-pyspark-viz/cookiecutter.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
"repo_name": "{{ cookiecutter.project_name.strip().replace(' ', '-').replace('_', '-').lower() }}",
"python_package": "{{ cookiecutter.project_name.strip().replace(' ', '_').replace('-', '_').lower() }}",
"kedro_version": "{{ cookiecutter.kedro_version }}",
"add_ons" : "none"
"add_ons": "['none']"
merelcht marked this conversation as resolved.
Show resolved Hide resolved
}
1 change: 1 addition & 0 deletions spaceflights-pyspark-viz/{{ cookiecutter.repo_name }}/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ namespaces = false
package_name = "{{ cookiecutter.python_package }}"
project_name = "{{ cookiecutter.project_name }}"
kedro_init_version = "{{ cookiecutter.kedro_version }}"
add_ons = {{ cookiecutter.add_ons | string | replace("\'", "\"") }}
merelcht marked this conversation as resolved.
Show resolved Hide resolved

[tool.pytest.ini_options]
addopts = """
Expand Down
2 changes: 1 addition & 1 deletion spaceflights-pyspark/cookiecutter.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
"repo_name": "{{ cookiecutter.project_name.strip().replace(' ', '-').replace('_', '-').lower() }}",
"python_package": "{{ cookiecutter.project_name.strip().replace(' ', '_').replace('-', '_').lower() }}",
"kedro_version": "{{ cookiecutter.kedro_version }}",
"add_ons": "none"
"add_ons": "['none']"
merelcht marked this conversation as resolved.
Show resolved Hide resolved
}
1 change: 1 addition & 0 deletions spaceflights-pyspark/{{ cookiecutter.repo_name }}/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ namespaces = false
package_name = "{{ cookiecutter.python_package }}"
project_name = "{{ cookiecutter.project_name }}"
kedro_init_version = "{{ cookiecutter.kedro_version }}"
add_ons = {{ cookiecutter.add_ons | string | replace("\'", "\"") }}
merelcht marked this conversation as resolved.
Show resolved Hide resolved

[tool.pytest.ini_options]
addopts = """
Expand Down