Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move logging.yml in spaceflights starters #177

Merged
merged 3 commits into from
Nov 1, 2023
Merged

Move logging.yml in spaceflights starters #177

merged 3 commits into from
Nov 1, 2023

Conversation

SajidAlamQB
Copy link
Contributor

@SajidAlamQB SajidAlamQB commented Oct 31, 2023

Motivation and Context

logging.yml in spaceflights-pandas-viz needs to be moved from conf/base/ to conf/. This was done for spaceflights-pyspark and spaceflights-pyspark-viz already.

There might be a few more that needs logging.yml moved as well.

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Assigned myself to the PR
  • Added tests to cover my changes

Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
@merelcht
Copy link
Member

I guess we'll need this for spaceflights-pandas as well for the example "add-on" option. Might as well do that in this PR and then just leave all the non spaceflights starters for another time.

Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
@noklam noklam enabled auto-merge (squash) November 1, 2023 11:08
@noklam noklam merged commit 41f2b98 into main Nov 1, 2023
17 of 18 checks passed
@noklam noklam deleted the move-logging branch November 1, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants