changed test_requirement.txt removed one line

[ANA-POTJE]

Description

Fixing the Github issue #119 Remove trufflehog pinned dependency in test_requirements.txt

Development notes

QA notes

Checklist

• Read the contributing guidelines
• Opened this PR as a 'Draft Pull Request' if it is work-in-progress
• Updated the documentation to reflect the code changes
• Added new entries to the RELEASE.md file
• Added tests to cover my changes

Legal notice

• I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

• I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

• I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

• I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

[921kiyo]

Thank you for the PR. It looks good to me 👍

• We would like to renogise your name in the release note, so could you please update RELEASE.md with your name and Github link please? So I will merge it once it is addressed.

• Also it is a good practice to add the description of which Github issue you are addressing in the PR ([KED-1404] Remove trufflehog pinned dependency in test_requirements.txt #119 in this case). So it would be great if you could update the PR description.

• Could you please click the checkbox in the PR (especially legal note)

Otherwise, great work and thank you for your contribution :)

[921kiyo]

Could you also update the lower bound of trufflehog to be
trufflehog>=2.1.0, <3.0 ?

[ANA-POTJE]

Thanks Kiyo! Some questions ...
(1) " .. update RELEASE.md with your name and Github link please? .."
I believe I should change RELEASE.md, then again: "git commit / git push / create a new PR, am I correct?

(2) " ... add the description of which Github issue you are addressing in the PR ..."
Done! Please check ...

(3) " .. Could you also update the lower bound of trufflehog to be trufflehog>=2.1.0, <3.0 ? .."
Is this a new request, or it is inside the same Github issue?
Should I update RELEASE.md, update the lower bound of trufflehog and then "git commit / git push ..."?

[ANA-POTJE]

Sorry, one more question … Where exactly in the RELEASE.md file should I include my name and GitHub link please? Should I include a section in the beginning of the file such as:
' ## supporting contributions
' Ana Potje
Thanks!

[921kiyo]

@ANA-POTJE
You don't need to create a new PR. You can update RELEASE.md and lower bound of trufflehog (I suggested the change below, which you can accept), then "git commit/ git push" in this PR.

For the RELEASE.md, see how the previous contributors added their name in https://github.com/quantumblacklabs/kedro/blob/develop/RELEASE.md

Let me know if anything is not clear :)

[921kiyo]

For FYI, see how the person updated the RELEASE.md in a PR. https://github.com/quantumblacklabs/kedro/pull/93/files

[ANA-POTJE]

Hi there, changes were done (included my name in RELEASE.md updated the lower bound of trufflehog to be trufflehog>=2.1.0, <3.0, as requested.
I managed to run a git commit successfully.
But I got an error in my git push … possibly because my local version cloned from kedro-viz is outdated (?), would you please kindly guide me? Thanks!!!

[ghost]

Hey @ANA-POTJE, thanks for this. It all seems fine here, so your git push seems to have worked. If you're getting an error, you might try git pull before git push but it's hard to say without the error.

Could you also please tick the legal notice box in the PR so we can merge your PR in? :)

[ANA-POTJE]

Hi Zain, "legal notice" box is ticked … I hope all ready for merge now? ;)

[ghost]

Merged. :)

[ANA-POTJE]

That's great!!! Very happy to help! :)))