Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KED-1450] Move visibleNav/navWidth calculations into redux store #124

Merged
merged 13 commits into from
Mar 13, 2020
Merged

[KED-1450] Move visibleNav/navWidth calculations into redux store #124

merged 13 commits into from
Mar 13, 2020

Commits on Mar 4, 2020

  1. Move visibleNav bool from component state to store

    @richardwestenra
    richardwestenra committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    66cb7a7 View commit details
    Browse the repository at this point in the history

  2. Move sidebar menu buttons into separate file

    @richardwestenra
    richardwestenra committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    059abfd View commit details
    Browse the repository at this point in the history

  3. Move navOffset/chartSize calcs into selector

    @richardwestenra
    richardwestenra committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    10bf609 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2020

  1. Fix tests

    @richardwestenra
    richardwestenra committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    15098a0 View commit details
    Browse the repository at this point in the history

  2. Add new layout tests

    @richardwestenra
    richardwestenra committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    d5b9a9d View commit details
    Browse the repository at this point in the history

  3. Handle undefined sidebarWidth

    @richardwestenra
    richardwestenra committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    cc57b02 View commit details
    Browse the repository at this point in the history

  4. Allow data prop to be overrriden in setup.mount

    @richardwestenra
    richardwestenra committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    ff6073d View commit details
    Browse the repository at this point in the history

  5. Allow initialState to be overridden by props 

    in mock state.mount
    @richardwestenra
    richardwestenra committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    0b3fd10 View commit details
    Browse the repository at this point in the history

  6. Change starting condition for sidebar test 

    This is so that it would fail properly if the simulated click didn't work
    @richardwestenra
    richardwestenra committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    ff5fad9 View commit details
    Browse the repository at this point in the history

  7. Add release note

    @richardwestenra
    richardwestenra committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    4eb000b View commit details
    Browse the repository at this point in the history

  8. Improve zoom selector, and pass {} when undefined 

    Better to pass an explicitly empty object when values have not been received (and handle the response down the ), than pass false values
    @richardwestenra
    richardwestenra committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    8c39b13 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2020

  1. Rename props in menu buttons to clarify intent 

    "'pipeline-sidebar__icon-button--visible': !visible" was confusing
    @richardwestenra
    richardwestenra committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    6095034 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary check 

    There is now a guard against width being undefined earlier in the function
    @richardwestenra
    richardwestenra committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    efaeb56 View commit details
    Browse the repository at this point in the history