[KED-1570] Experiment with layer ordering and assignment client-side #147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces logic to:
layer: null
for every Kedro node in the mock data.layer: null
for some dataset.The reason
layer: null
works is because a graph node is always assigned a rank, so it will get displayed based on its topological order in any case. If there is a layer assigned, it just means this layer changes the node's topological order and the node is displayed in the same rank as other nodes in the same layer.An interesting property of the way we add fake edges between layers is that a Kedro node will be displayed on the same layer as its output dataset if its input dataset is in the layer below, which is in line with data engineer's convention.
Development notes
QA notes
Checklist
RELEASE.md
fileLegal notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":
I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.
I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.