Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KED-1564] Make dataPath relative again #149

Merged
merged 2 commits into from
Apr 28, 2020
Merged

Conversation

richardwestenra
Copy link
Contributor

Description

Raised by @gbraccialli-qb:

"Last year, I requested Viz to work on relative paths, it's helpful to use it on jupyter hub proxy and publish it to users that don't have kedro installed locally. It was added in [the old internal version of Viz], but it doesn't work on latest version of kedro-viz. Is it possible to add it back?"

Development notes

I've added a new test to ensure that I don't break this again 🙈

QA notes

n/a

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Legal notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

Resolves KED-1564
@richardwestenra richardwestenra merged commit fcdb9e4 into develop Apr 28, 2020
@richardwestenra richardwestenra deleted the fix/relative-paths branch April 28, 2020 11:56
@WaylonWalker
Copy link
Contributor

kedro-static-viz could be another simple option to visualize pipelines from places that do not have the pipeline installed. If you can hook it into ci and host it on GitHub pages or s3 its quite handy to have viz available anywhere. https://github.com/WaylonWalker/kedro-static-viz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants