[KED-1613] Remove node active state from mid-level node selectors #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The node active state changes often (e.g. on mouseover), and changing it triggers a complete update of a lot of more expensive filtering operations that are unaffected by whether a node is active (i.e. highlighted/hovered). Removing this prop from these mid-level selectors and adding it in at the render stage means that these selectors won't need to run as often, which should slightly improve mouseover performance.
richardwestenra
changed the title
bru5
approved these changes
Apr 29, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The node active state changes often (e.g. on mouseover), and changing it triggers a complete update of a lot of more expensive filtering operations that are unaffected by whether a node is active (i.e. highlighted/hovered). Removing this prop from these mid-level selectors and adding it in at the render stage means that these selectors won't need to run as often, which should slightly improve mouseover performance.
Checklist
RELEASE.mdfileLegal notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":
I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.
I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.