[KED-1638] Update colour scheme, improve print/export styles #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename main bg colour variables to -1, -2, -3 - Remove node-highlighted class, as it's pretty much unnecessary - Rename node highlighted variable to active, and active to selected, as these are what they're being used for
This is to avoid compatibility issues with global classes when embedded in other projects
1. Ensure that the chart displays well when printing, by hiding the sidebar and layers, and making it reset to 100% width 2. Add new styles for both print and export, especially the light theme, which has a white/transparent background, so the nodes need a different stroke and fill. Also make the background solid for dark exported images
bru5
approved these changes
May 21, 2020
bru5
approved these changes
May 21, 2020
Safari treats transparent as rgba(0,0,0,0), so it fades the hue to black as it changes the opacity. This fix avoids this problem by keeping the hue the same, and only changing the opacity.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@mediaprint styles, so that it will print properly - see the image preview if you hit Cmd+PDark theme:
Light theme:
Development notes
QA notes
Need to test exporting images (both PNG/SVG), and printing, in both themes.
See also tooltips etc.
Checklist
RELEASE.mdfileLegal notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":
I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.
I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.