Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
  • Loading branch information
Ahdra Merali committed Sep 19, 2023
1 parent 08567d3 commit 7fca19e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions kedro/templates/project/hooks/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

current_dir = Path.cwd()

lint_requirements = "black\nruff\n"
lint_requirements = "black~=22.12.0\nruff~=0.0.290\n"
lint_pyproject_requirements = """
[tool.ruff]
select = [
Expand All @@ -15,7 +15,7 @@
"I", # isort
"PL", # Pylint
]
ignore = ["E501"] # Black takes care off line-too-long
ignore = ["E501"] # Black takes care of line-too-long
"""

test_requirements = "pytest-cov~=3.0\npytest-mock>=1.7.1, <2.0\npytest~=7.2"
Expand Down
6 changes: 3 additions & 3 deletions tests/framework/cli/test_starters.py
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ def _assert_requirements_ok(
"I", # isort
"PL", # Pylint
]
ignore = ["E501"] # Black take care off line-too-long
ignore = ["E501"] # Black takes care of line-too-long
"""
)
in requirements
Expand Down Expand Up @@ -860,8 +860,8 @@ def test_invalid_add_ons(self, fake_kedro_cli):
)

assert result.exit_code != 0
assert "is an invalid value for Project Add-Ons." in result.output
assert "is an invalid value for project add-ons." in result.output
assert (
"Invalid input. Please select valid options for add-ons using comma-separated values, ranges, or 'all/none'.\n"
"Please select valid options for add-ons using comma-separated values, ranges, or 'all/none'.\n"
in result.output
)

0 comments on commit 7fca19e

Please sign in to comment.