Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warnings to all the kedro.extras.datasets to explain they're moving #1501

Closed
merelcht opened this issue May 4, 2022 · 3 comments · Fixed by #2546
Closed

Comments

@merelcht
Copy link
Member

merelcht commented May 4, 2022

and/or potentially the AbstractDataset classes after it's decided whether they are moving or not.

@merelcht
Copy link
Member Author

This is no longer needed after the decision to make kedro-datasets namespaced. The imports for kedro.extras.datasets will still work until the rename in 0.19.0.

@merelcht merelcht moved this to Done in Kedro Framework Jul 14, 2022
@astrojuanlu
Copy link
Member

After a discussion during technical design, we have concluded that namespacing is not the correct approach for the kedro-datasets split. Further details and discussion can be seen under #1758.

Originally posted by @AhdraMeraliQB in #1693 (comment)

Reopening this issue.

@astrojuanlu astrojuanlu reopened this Apr 20, 2023
@github-project-automation github-project-automation bot moved this from Done to In Progress in Kedro Framework Apr 20, 2023
@astrojuanlu astrojuanlu moved this from In Progress to To Do in Kedro Framework Apr 20, 2023
@astrojuanlu
Copy link
Member

astrojuanlu commented Apr 20, 2023

I think we should:

astrojuanlu added a commit that referenced this issue Apr 27, 2023
Fix gh-1501.

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
astrojuanlu added a commit that referenced this issue Apr 27, 2023
Fix gh-1501.

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
@github-project-automation github-project-automation bot moved this from To Do to Done in Kedro Framework Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants