Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mermaid JS included too many times #2451

Closed
astrojuanlu opened this issue Mar 22, 2023 · 0 comments · Fixed by #2452
Closed

Mermaid JS included too many times #2451

astrojuanlu opened this issue Mar 22, 2023 · 0 comments · Fixed by #2452
Labels
Component: Documentation 📄 Issue/PR for markdown and API documentation Issue: Bug Report 🐞 Bug that needs to be fixed

Comments

@astrojuanlu
Copy link
Member

I was noticing general slowness in our docs and lots of waiting time on unpkg, so I opened the source and noticed this in our docs:

<script src="[https://unpkg.com/mermaid/dist/mermaid.min.js](view-source:https://unpkg.com/mermaid/dist/mermaid.min.js)"></script>
        <script >mermaid.initialize({startOnLoad:true});</script>
        <script src="[https://unpkg.com/mermaid/dist/mermaid.min.js](view-source:https://unpkg.com/mermaid/dist/mermaid.min.js)"></script>
        <script >mermaid.initialize({startOnLoad:true});</script>
        <script src="[https://unpkg.com/mermaid/dist/mermaid.min.js](view-source:https://unpkg.com/mermaid/dist/mermaid.min.js)"></script>
        <script >mermaid.initialize({startOnLoad:true});</script>
        <script src="[https://unpkg.com/mermaid/dist/mermaid.min.js](view-source:https://unpkg.com/mermaid/dist/mermaid.min.js)"></script>
        <script >mermaid.initialize({startOnLoad:true});</script>
        <script src="[https://unpkg.com/mermaid/dist/mermaid.min.js](view-source:https://unpkg.com/mermaid/dist/mermaid.min.js)"></script>
        <script >mermaid.initialize({startOnLoad:true});</script>
        <script src="[https://unpkg.com/mermaid/dist/mermaid.min.js](view-source:https://unpkg.com/mermaid/dist/mermaid.min.js)"></script>
        <script >mermaid.initialize({startOnLoad:true});</script>
        <script src="[https://unpkg.com/mermaid/dist/mermaid.min.js](view-source:https://unpkg.com/mermaid/dist/mermaid.min.js)"></script>
        <script >mermaid.initialize({startOnLoad:true});</script>
        <script src="[https://unpkg.com/mermaid/dist/mermaid.min.js](view-source:https://unpkg.com/mermaid/dist/mermaid.min.js)"></script>
        <script >mermaid.initialize({startOnLoad:true});</script>
        <script src="[https://unpkg.com/mermaid/dist/mermaid.min.js](view-source:https://unpkg.com/mermaid/dist/mermaid.min.js)"></script>
        <script >mermaid.initialize({startOnLoad:true});</script>
        <script src="[https://unpkg.com/mermaid/dist/mermaid.min.js](view-source:https://unpkg.com/mermaid/dist/mermaid.min.js)"></script>
        <script >mermaid.initialize({startOnLoad:true});</script>
        <script src="[https://unpkg.com/mermaid/dist/mermaid.min.js](view-source:https://unpkg.com/mermaid/dist/mermaid.min.js)"></script>
..

And I had to cut it because...

image

@astrojuanlu astrojuanlu added Component: Documentation 📄 Issue/PR for markdown and API documentation Issue: Bug Report 🐞 Bug that needs to be fixed labels Mar 22, 2023
astrojuanlu added a commit that referenced this issue Mar 22, 2023
Fix gh-2451.

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
astrojuanlu added a commit that referenced this issue Mar 22, 2023
* Do not initialize Mermaid JS

Fix gh-2451.

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

* Allow warnings in documentation

"Temporary" (hopefully) workaround for gh-2453.

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

---------

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
jmholzer pushed a commit that referenced this issue Mar 29, 2023
* Do not initialize Mermaid JS

Fix gh-2451.

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

* Allow warnings in documentation

"Temporary" (hopefully) workaround for gh-2453.

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

---------

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Signed-off-by: Jannic Holzer <jannic.holzer@quantumblack.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Documentation 📄 Issue/PR for markdown and API documentation Issue: Bug Report 🐞 Bug that needs to be fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant