-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the error message & docstring of kedro new
for custom starters
#2618
Comments
kedro new
starterkedro new
for custom starters
Hey @astrojuanlu, @merelcht, |
Hi @MinuraPunchihewa , thanks for stepping in! @AhdraMeraliQB does this somehow conflict with the new add-ons flow? |
CC: @noklam
The error message results if an official Kedro starter-alias is used with Option: "Cannot use the --directory flag with a Kedro starter alias." I agree that this should be visibly documented, an addition should be made to https://docs.kedro.org/en/stable/starters/starters.html, but I'm unsure the error message itself needs to be modified |
Signed-off-by: Dominik <dominikzalewski97@gmail.com>
PR is ready: #3771 |
Signed-off-by: Dominik <dominikzalewski97@gmail.com>
Signed-off-by: Dominik <dominikzalewski97@gmail.com>
Signed-off-by: Dominik <dominikzalewski97@gmail.com>
Signed-off-by: Dominik Zalewski <dominikzalewski97@gmail.com>
Signed-off-by: Dominik Zalewski <dominikzalewski97@gmail.com>
Signed-off-by: Dominik Zalewski <dominikzalewski97@gmail.com>
Signed-off-by: Dominik Zalewski <dominikzalewski97@gmail.com>
This was addressed in #3771! |
Part of #2604
Context
The error message of
kedro new
is not very accurate. This was found when we try to usekedro new
for a new starter that haven't been added to the official starters list.There are at least 2 common ways (Added more if found)
kedro new -s pandas-iris
, usingkedro new
for official starterskedro new --starter <some_directory> --checkout <branch> --directory <directory>
, use it for custom starters in local or repository (not documented)should be documented as it is not easy to figure out with the docstring and CLI help message. In addition, the error message isn't accurate
This is very confusing because to do 2. you need to use both
starter
anddirectory
, but the error message says the opposite.i.e.
kedro new --starter git+https://github.com/kedro-org/kedro-starters.git --directory databricks-iris --checkout feat/modify-pyspark-iris-databricks-packaged-deployment
(This works)The help message have some information about --starter flag can be provided as a git URL
Action
The text was updated successfully, but these errors were encountered: