Pin pytables to match version installed through conda #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenabalan
approved these changes
Jan 6, 2022
|
Thanks for doing this! Looks like a good fix for the windows tests, but should we be changing this requirement too (just for windows like @lorenabalan suggested)? https://github.com/quantumblacklabs/kedro/blob/main/setup.py#L80 I'm not sure whether we should or not. On the one hand, would be nice to keep things consistent, but on the other since this wouldn't be released for a while maybe we should just wait until pytables have come out with a fix and then change to that new version. I don't know. |
|
Yep good points, I'll specify the operating system on the requirements and update |
rashidakanchwala
approved these changes
Jan 7, 2022
idanov
approved these changes
Jan 7, 2022
rashidakanchwala
pushed a commit
that referenced
this pull request
Jan 10, 2022
Signed-off-by: Rashida Kanchwala <rashida.kanchwala@quantumblack.com>
doytsujin
pushed a commit
to doytsujin/kedro
that referenced
this pull request
Jan 22, 2022
…kedro-org#1139) * Update deployment docs to use direct call to pipelines instead of through context * Fix lint
lvijnck
pushed a commit
to lvijnck/kedro
that referenced
this pull request
Apr 7, 2022
Signed-off-by: Laurens Vijnck <laurens_vijnck@mckinsey.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
win_unit_tests_3.8are failing on several PRs with aWindow stackoverflowerror which seems to be related to pytables. Pytables have released a new version 9 days ago, but it’s not on conda-forge, so in our windows CI we install pytables3.6.1throughconda install -c conda-forge pytables -yand then in a later step when all requirements are installed pip installs the latest pytables version, which is now3.7.0.Development notes
I’m not entirely sure why the errors are only happening on 3.8 (this might be related: PyTables/PyTables#933), but pinning
tablesintest_requirements.txtseems to fix it for now.Checklist
RELEASE.mdfile