Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KED-3046] Remove "QuantumBlack Labs" from places where it doesn't belong any more #1161

Merged
merged 7 commits into from
Jan 21, 2022

Conversation

SajidAlamQB
Copy link
Contributor

Description

There's a few mentions that kedro is authored by QuantumBlack Labs (e.g. in kedro docs, setup.,py, kedro info). Following the migration to LF these shouldn't be there any more.

Best way to find them is just to search "quantumblack" in the codebase - there's not that many results to check through.

Additionally you will also have to update URLs for Kedro-Airflow, Kedro-Docker and Kedro-Telemetry as they have completely changed repo location.

As well as kedro repository, you should check kedro-community, kedro-plugins, kedro-viz and kedro-training. kedro-starters has already been updated.

https://jira.quantumblack.com/browse/KED-3046

Development notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes

Copy link
Contributor

@lorenabalan lorenabalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. 👌

@antonymilne
Copy link
Contributor

Looks good so far, but I think there's a few more places which might need updating:

  • recently merged docs/source/03_tutorial/07_set_up_experiment_tracking.md points to the old kedro-viz repo URL
  • do we still want to use kedro@quantumblack.com - @yetudada?
  • very minor, but the stuff under "Set git email and name" in CircleCI config

merelcht pushed a commit that referenced this pull request Jan 19, 2022
[AUTO-MERGE] Merge master into develop via merge-master-to-develop
Copy link
Contributor

@yetudada yetudada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved and I think let's remove the kedro@quantumblack.com email addresses from the code base and instead tell users to raise GitHub issues or reach us on Discord to find us.

docs/conf.py Outdated Show resolved Hide resolved
kedro/framework/cli/cli.py Outdated Show resolved Hide resolved
docs/source/09_development/03_commands_reference.md Outdated Show resolved Hide resolved
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SajidAlamQB SajidAlamQB merged commit b9fba67 into main Jan 21, 2022
@SajidAlamQB SajidAlamQB deleted the Remove-references-to-QuantumBlack-Labs-#ked-3046 branch January 21, 2022 14:56
lvijnck pushed a commit to lvijnck/kedro that referenced this pull request Apr 7, 2022
…long any more (kedro-org#1161)

* removed appropriate references to QuantumBlack

* Update 07_set_up_experiment_tracking.md

* changes based on reviews

* removing qb emails for git config

Signed-off-by: Laurens Vijnck <laurens_vijnck@mckinsey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants