Pin upper pandas version requirement #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antony Milne <antony.milne@quantumblack.com>
Signed-off-by: Antony Milne <antony.milne@quantumblack.com>
lorenabalan
approved these changes
Jan 27, 2022
There was a problem hiding this comment.
Tbh I think this is perfectly fine. At the end of the day, users can still install newer pandas themselves with pip install pandas rather than through pip install kedro[pandas], and they would have to be careful to use openpyxl instead of xlrd. This won't be as much of a problem in 0.18 cause we default to openpyxl then.
datajoely
approved these changes
Jan 27, 2022
SajidAlamQB
approved these changes
Jan 27, 2022
Signed-off-by: Antony Milne <antony.milne@quantumblack.com>
Galileo-Galilei
pushed a commit
to Galileo-Galilei/kedro
that referenced
this pull request
Feb 19, 2022
* Add reference to layers medium article * Update docs/source/12_faq/01_faq.md Co-authored-by: Merel Theisen <49397448+MerelTheisenQB@users.noreply.github.com> * Update 01_faq.md Fix spacing * Update docs/source/12_faq/01_faq.md Co-authored-by: Jo Stichbury <stichbury@users.noreply.github.com> Co-authored-by: Merel Theisen <49397448+MerelTheisenQB@users.noreply.github.com> Co-authored-by: Jo Stichbury <stichbury@users.noreply.github.com>
lvijnck
pushed a commit
to lvijnck/kedro
that referenced
this pull request
Apr 7, 2022
Signed-off-by: Laurens Vijnck <laurens_vijnck@mckinsey.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1179. pandas have released 1.4.0, which requires
xlrd>=2.0.1(and is only compatible with Python >=3.8). This is incompatible with ourxlrd~=1.0.Development notes
Note that pandas was unpinned in August 2020 in https://github.com/quantumblacklabs/private-kedro/pull/772. In hindsight we probably should have reinstated an upper bound some time after that. I've done so now to restrict to
<1.4.The alternative to this was to allow pandas 1.4 and relax our requirement for xlrd to include 2.0.1. I opted not to do this since xlrd 2.0 introduced breaking changes.
Questions
pandas>=1.4which is maybe annoying for users who want to use any new features in those releases. We could do something to make the version of xlrd installed depend on the version of pandas so that not everyone getsxlrd>=2.0, but that seemed like overkill to me.pandas~=1.3)?Checklist
RELEASE.mdfile