Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ";" to os.pathsep #1188

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Change ";" to os.pathsep #1188

merged 1 commit into from
Feb 1, 2022

Conversation

antonymilne
Copy link
Contributor

Description

Fixes #1183.

Before this, my local PYTHONPATH looked like this. Note the inconsistent ; at the beginning compared to all the other :. I don't know if this actually caused any problems for anyone, but it should cause even fewer problems now anyway 😅

/Users/antony_milne/kedro_stuff/projects/spaceflights/src;/Users/antony_milne/kedro_stuff/projects:/Users/antony_milne/kedro_stuff/kedro:/Applications/PyCharm.app/Contents/plugins/python/helpers/pycharm_matplotlib_backend:/Applications/PyCharm.app/Contents/plugins/python/helpers/pycharm_display:/Applications/PyCharm.app/Contents/plugins/python/helpers/third_party/thriftpy:/Applications/PyCharm.app/Contents/plugins/python/helpers/pydev:/Users/antony_milne/Library/Caches/JetBrains/PyCharm2021.3/cythonExtensions:/Users/antony_milne/kedro_stuff/projects/spaceflights

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes

@antonymilne
Change ";" to os.pathsep
9fd9228 
Signed-off-by: Antony Milne <antony.milne@quantumblack.com>
@antonymilne antonymilne mentioned this pull request Feb 1, 2022
Closed
@idanov idanov merged commit 8e5bb6b into main Feb 1, 2022
@idanov idanov deleted the bugfix/os.pathsep branch February 1, 2022 11:31
antonymilne pushed a commit that referenced this pull request Feb 1, 2022
@idanov
Merge pull request #1188 from quantumblacklabs/merge-master-to-develop
523e784 
[AUTO-MERGE] Merge master into develop via merge-master-to-develop
lvijnck pushed a commit to lvijnck/kedro that referenced this pull request Apr 7, 2022
@antonymilne @lvijnck
Change ";" to os.pathsep (kedro-org#1188)
4239137 
Signed-off-by: Antony Milne <antony.milne@quantumblack.com>
Signed-off-by: Laurens Vijnck <laurens_vijnck@mckinsey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idanov idanov idanov approved these changes

@lorenabalan lorenabalan lorenabalan approved these changes

@SajidAlamQB SajidAlamQB SajidAlamQB approved these changes

@merelcht merelcht Awaiting requested review from merelcht merelcht is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kedro ipython PYTHONPATH
4 participants
@antonymilne @idanov @lorenabalan @SajidAlamQB