Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CustomContext example for PySpark in docs #1452

Merged
merged 1 commit into from
Apr 20, 2022
Merged

Fix CustomContext example for PySpark in docs #1452

merged 1 commit into from
Apr 20, 2022

Conversation

SajidAlamQB
Copy link
Contributor

@SajidAlamQB SajidAlamQB commented Apr 20, 2022 •
edited by gitpod-io bot
Loading

Signed-off-by: SajidAlamQB 90610031+SajidAlamQB@users.noreply.github.com

Description

Related issue: #1425
Related PR: kedro-org/kedro-starters#83

This fixes the outdated CustomContext example code for pyspark in our documentation.

Development notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes

@SajidAlamQB
Fix pyspark example in docs
7d63b90 
Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
@SajidAlamQB SajidAlamQB requested a review from yetudada as a code owner April 20, 2022 10:33
@SajidAlamQB SajidAlamQB self-assigned this Apr 20, 2022
@SajidAlamQB SajidAlamQB changed the title Fix CustomContext example for PySpark in docs Fix CustomContext example for PySpark in docs Apr 20, 2022
noklam
noklam approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@noklam noklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

merelcht
merelcht approved these changes Apr 20, 2022
View reviewed changes
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

antonymilne
antonymilne approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@antonymilne antonymilne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@SajidAlamQB SajidAlamQB merged commit 1b15589 into main Apr 20, 2022
@SajidAlamQB SajidAlamQB deleted the docs/Fix-CustomContext-example-for-PySpark branch April 20, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merelcht merelcht merelcht approved these changes

@antonymilne antonymilne antonymilne approved these changes

@noklam noklam noklam approved these changes

@yetudada yetudada Awaiting requested review from yetudada yetudada is a code owner

@AhdraMeraliQB AhdraMeraliQB Awaiting requested review from AhdraMeraliQB

Assignees

@SajidAlamQB SajidAlamQB

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SajidAlamQB @noklam @antonymilne @merelcht