-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update linting page to add flake8 configuration (and make some minor improvements) #2517
Conversation
Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a neat improvement over what we have now, but left a few comments, mainly food for thought (not necessarily for this PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is great work. These docs will be in a much better state after this merge.
Co-authored-by: Jannic <37243923+jmholzer@users.noreply.github.com>
Description
Created in response to #2473 to add a small amount of information about configuration.
Also added a few minor tweaks to clarify the purpose of formatting/linting and the differences between them.
Development notes
Changed one file, linted, rebuilt and inspected.
I'd value input on whether there's more configuration information I could add here or if I've put the most useful information in (to mirror what we do for the starters). I notice that we have slightly different config for flake8 for the Kedro project itself...would it be useful to add any other commonly used settings?
Checklist
RELEASE.md
file