Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting entry in the RELEASE.md file #270

Merged
merged 2 commits into from
Mar 10, 2020

Conversation

neomatrix369
Copy link
Contributor

Description

Docs: corrected previous release notes entry (via PR #266, related to issue #256)

Development notes

No code changes, just amending RELEASE.md

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change and added my name to the list of supporting contributions in the RELEASE.md file
  • Added tests to cover my changes

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@neomatrix369 neomatrix369 requested a review from idanov as a code owner February 28, 2020 16:41
Copy link
Contributor

@921kiyo 921kiyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@neomatrix369 neomatrix369 force-pushed the update-contribution-guide branch from 920d810 to b4892fe Compare March 2, 2020 15:53
@neomatrix369
Copy link
Contributor Author

Any chance of this been merged, its pretty trivial and no code or Kedro documentation changes involved

@mzjp2
Copy link
Contributor

mzjp2 commented Mar 9, 2020

Can you fix the conflict before we merge? :)

@neomatrix369 neomatrix369 force-pushed the update-contribution-guide branch from b4892fe to b41f7e5 Compare March 9, 2020 11:12
@neomatrix369
Copy link
Contributor Author

Can you fix the conflict before we merge? :)

I keep fixing it - they will continue to occur if not merged quickly

@neomatrix369
Copy link
Contributor Author

@mzjp2 just fixed, it's being built now

@limdauto
Copy link
Contributor

Closing / Reopening the PR to re-trigger CI.

@limdauto limdauto closed this Mar 10, 2020
@limdauto limdauto reopened this Mar 10, 2020
@limdauto limdauto merged commit 9461e17 into kedro-org:develop Mar 10, 2020
@neomatrix369 neomatrix369 deleted the update-contribution-guide branch March 10, 2020 16:17
@neomatrix369
Copy link
Contributor Author

Thanks all for merging this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants