Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mute deprecation warnings coming from io.core that a user can't change #3186

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

merelcht
Copy link
Member

@merelcht merelcht commented Oct 17, 2023

Description

Resolves #3107

Development notes

Added warnings filter to not show KedroDeprecationWarning for the imports inside io.core, because a user can't change those. The deprecation warning will still be shown if a user directly access any of the core datasets.

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@merelcht merelcht self-assigned this Oct 17, 2023
Copy link
Contributor

@ankatiyar ankatiyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @merelcht! 🚀

@merelcht merelcht enabled auto-merge (squash) October 17, 2023 17:14
@merelcht merelcht merged commit 6cad4f3 into main Oct 18, 2023
56 of 65 checks passed
@merelcht merelcht deleted the deprecation-warnings-core branch October 18, 2023 09:19
adamkells pushed a commit to adamkells/kedro that referenced this pull request Oct 30, 2023
kedro-org#3186)

Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Adam Kells <adamjkells93@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assess how intrusive the dataset deprecation warnings are
3 participants