Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nightly build to develop branch #3215

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Conversation

ankatiyar
Copy link
Contributor

NOTE: Kedro datasets are moving from kedro.extras.datasets to a separate kedro-datasets package in
kedro-plugins repository. Any changes to the dataset implementations
should be done by opening a pull request in that repository.

Description

Fix #3208

Development notes

  • Add main and develop as strategy matrix options to nightly build
  • Pass the "branch" input down to the reusable workflows
  • "branch" input is used with actions/checkout@v3 to checkout the appropriate branch

Tested on my fork - https://github.com/ankatiyar/kedro/actions/runs/6611457423

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Copy link
Contributor

@SajidAlamQB SajidAlamQB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀

@ankatiyar ankatiyar merged commit 5ac14c3 into main Oct 23, 2023
45 of 65 checks passed
@ankatiyar ankatiyar deleted the ci/nightly-build-develop branch October 23, 2023 15:58
@ankatiyar ankatiyar mentioned this pull request Oct 24, 2023
7 tasks
adamkells pushed a commit to adamkells/kedro that referenced this pull request Oct 30, 2023
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Signed-off-by: Adam Kells <adamjkells93@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add nightly build to develop branch
3 participants