-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update add-on test to parse pyproject.toml #3230
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
This was referenced Oct 25, 2023
Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
7 tasks
I'll change this to merge into #3228 instead of |
Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
noklam
added a commit
that referenced
this pull request
Nov 3, 2023
* adapt pyspark add-ons Signed-off-by: Nok <nok.lam.chan@quantumblack.com> * fix promopt Signed-off-by: Nok <nok.lam.chan@quantumblack.com> * fix minor stuff in prompt Signed-off-by: Nok <nok.lam.chan@quantumblack.com> * refactor utils and fix template switch to starters Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com> * lint Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com> * Refactor utils.py use toml and unstrip pyproject.toml and requirements.txt Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com> * fix broken test missing options 7 Signed-off-by: Nok <nok.lam.chan@quantumblack.com> * add more test Signed-off-by: Nok <nok.lam.chan@quantumblack.com> * fix test Signed-off-by: Nok <nok.lam.chan@quantumblack.com> * attempt to fix tests Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com> * fix test Signed-off-by: Nok <nok.lam.chan@quantumblack.com> * remove reporting when viz selected Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com> * update tests for viz add-on Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com> * remove reporting.yml and update tests Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com> * add comment to _get_expected_files number counts Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com> * Update tests to parse pyprojec.toml (#3230) Signed-off-by: Nok <nok.lam.chan@quantumblack.com> Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> * Add .gitkeep for conf/local/ Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com> * Fix tests Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com> * add comments for more context Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com> * More descriptive variable names Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com> * changes based on review - use patterns to remove parameter files Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com> * changes based on review cleaner template switching with more comments Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com> * add full stop to comment (nit) Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com> * Replace anyconfig with toml for tests Signed-off-by: Nok <nok.lam.chan@quantumblack.com> * add docstrings Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com> * add docstrings to helper methods and make them private Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com> * update docstring Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com> * changes based on review Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com> * lint Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com> --------- Signed-off-by: Nok <nok.lam.chan@quantumblack.com> Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com> Signed-off-by: Sajid Alam <90610031+SajidAlamQB@users.noreply.github.com> Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com> Co-authored-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #3169 - #3169 (comment)
It catches a bug that when using the combination of [2,3,4], an invalid configuration is created.
@SajidAlamQB @merelcht
Development notes
Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-by
line in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.md
file