-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cli.py
template in docs
#3428
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
AhdraMeraliQB
requested review from
yetudada,
astrojuanlu and
stichbury
as code owners
December 14, 2023 16:40
AhdraMeraliQB
requested review from
merelcht and
ankatiyar
and removed request for
yetudada
December 14, 2023 16:40
merelcht
approved these changes
Dec 15, 2023
ankatiyar
approved these changes
Dec 15, 2023
AhdraMeraliQB
added a commit
that referenced
this pull request
Dec 19, 2023
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
AhdraMeraliQB
added a commit
that referenced
this pull request
Dec 20, 2023
* unique tool entires and QoL for pyproject.toml Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com> Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * revert unique entries change Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com> Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Update cli.py template (#3428) Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Add logging about not using async for Sequential and Parallel runners (#3424) Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com> Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Don't include requirements only needed for example pipeline (#3425) * remove example pipeline requirements Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com> * lint Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com> * simplify amending kedro[...] lines Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com> * keep the version for datasets Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com> * lint Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com> --------- Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com> Signed-off-by: Sajid Alam <90610031+SajidAlamQB@users.noreply.github.com> Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Sort `requirements.txt` based on package name only (#3436) * Sort `requirements.txt` based on package name only Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * Remove now-unused custom `requirements.txt` sorter Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * Ruff format kedro/templates/project/hooks/utils.py Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * Pass the right argument to `fix_requirements` call Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * Add `sort_requirements` until starters are updated Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * Wrap lib call in existing method for compatibility Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> --------- Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Pass tools through as list Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Revert "Pass tools through as list" This reverts commit f4a4a15. Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Remove duplicates Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Fix for no add-ons selected Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Lint Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Add example as recognised key Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Add example as recognised key pt2 Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Add example as recognised key pt3 Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Add example as recognised key pt4 Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Add example as recognised key pt5 Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Add example as recognised key pt6 Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Add example as recognised key pt7 Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Streamline condition Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> --------- Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com> Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com> Signed-off-by: Sajid Alam <90610031+SajidAlamQB@users.noreply.github.com> Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> Co-authored-by: Ahdra Merali <90615669+AhdraMeraliQB@users.noreply.github.com> Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com> Co-authored-by: Deepyaman Datta <deepyaman.datta@utexas.edu> Co-authored-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Outcome of #3347
Development notes
Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-by
line in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.md
file