-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor tech debts #3429
Minor tech debts #3429
Conversation
Signed-off-by: Dmitry Sorokin <dmd40in@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks cleaner now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is some awesome refactoring and simplification, thank you @DimedS its looking a lot cleaner now! 🔥
@@ -666,12 +625,13 @@ def _make_cookiecutter_context_for_prompts(cookiecutter_dir: Path): | |||
return cookiecutter_context.get("cookiecutter", {}) | |||
|
|||
|
|||
def _make_cookiecutter_args( | |||
def _make_cookiecutter_args_and_fetch_template( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I like this.
Description
This PR closes few issues from #3264:
4:
6:
centralising all regex checks in _validate_regex() func
And lines 433-439 were removed as they were deemed unnecessary (modified return to {} instead of None in line 337 to make it possible)
Development notes
Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-by
line in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.md
file