Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit mypy setup #3485

Merged
merged 13 commits into from
Jan 11, 2024
Merged

Revisit mypy setup #3485

merged 13 commits into from
Jan 11, 2024

Conversation

merelcht
Copy link
Member

@merelcht merelcht commented Jan 5, 2024

Description

Part of #2156

Development notes

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@merelcht merelcht self-assigned this Jan 5, 2024
@merelcht merelcht requested review from noklam and AhdraMeraliQB and removed request for stichbury and yetudada January 5, 2024 11:36
@merelcht merelcht mentioned this pull request Jan 8, 2024
7 tasks
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Copy link
Contributor

@noklam noklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Approved with one non-blocking comment about dependencies.

Makefile Show resolved Hide resolved
kedro/config/omegaconf_config.py Outdated Show resolved Hide resolved
Copy link
Contributor

@AhdraMeraliQB AhdraMeraliQB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Love that we're not overwriting variable names anymore, it's a lot easier to read. Just a (non-blocking) QQ - sometimes we have var: Type | None and other times var: None | Type - is there a rule or convention we should apply in terms of what should go first? Or alternatively, is consistency not a priority for typing?

Copy link
Contributor

@DimedS DimedS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @merelcht !

@astrojuanlu
Copy link
Member

+1 for var: Type | None rather than None | Type!

@merelcht
Copy link
Member Author

Looks great! Love that we're not overwriting variable names anymore, it's a lot easier to read. Just a (non-blocking) QQ - sometimes we have var: Type | None and other times var: None | Type - is there a rule or convention we should apply in terms of what should go first? Or alternatively, is consistency not a priority for typing?

Ha yeah good spot. I started on this with None | Type and later decided I preferred the other way around, but forgot to change that everywhere. Will do that before merging!

merelcht and others added 2 commits January 11, 2024 11:21
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@merelcht merelcht enabled auto-merge (squash) January 11, 2024 11:22
@merelcht merelcht merged commit 5e80b79 into main Jan 11, 2024
36 checks passed
@merelcht merelcht deleted the revisit-mypy-setup branch January 11, 2024 11:51
@merelcht merelcht mentioned this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants