-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable rich markup if rich handler is not present #3682
Merged
Merged
Changes from 13 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
15f97da
Rich utils
sbrugman 62ece11
Conditional logging data_catalog
sbrugman 0a4edb5
Update data_catalog.py
sbrugman 86a8842
Update logging.py
sbrugman 0742860
Add unit tests
sbrugman 931235e
Update test_logging.py
sbrugman c7bb278
Lint
sbrugman b72677a
Cache `has_rich_logger`
sbrugman 6caf7e8
Backwards compatibility 3.8
sbrugman db167bd
Merge branch 'main' into patch-4
noklam 275725e
Merge branch 'main' into patch-4
sbrugman 802ad26
Update test_logging.py
sbrugman 5548466
Merge branch 'main' into patch-4
lrcouto e290871
Revert "Update test_logging.py"
lrcouto 19e17fe
Revert merge
lrcouto d3dadfc
revert test_logging.py to commit 802ad26
lrcouto d14576c
Fix test, apply small fixes
lrcouto 4349dc0
Merge branch 'patch-4' of https://github.com/sbrugman/kedro into patch-4
lrcouto 505a593
Fix non-matching character in expected_message
lrcouto 956ceea
Remove leftover print
lrcouto 326ea75
Merge branch 'main' into patch-4
lrcouto e4968d3
fix test
noklam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I would just leave out this comment; pyupgrade will take care of it when drop 3.8.