-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Key completion for dataset access #3973
Key completion for dataset access #3973
Conversation
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, I have some questions:
- When I try to prompt the autocompletion, it seems to prompt me to use the single quote instead of the more common
"
in Python. Is this something we can control or it's how IPython completion works? If I typecatalog.datasets["]
and hit tab then it would finish the autocompletion without the finishing"
, which means a few more keystrokes. This is not a deal breaker but just want to check if we can make this experience smoother.
@datajoely, regarding your question about placing parameters at the bottom - sorting is applied internally in |
Sounds good! @ElenaKhaustova , I petition that we drop the |
Yes, that's the way IPython completion works and there's no any API to customise it from the outside. I see some logic for matching the closing quote but it's not straightforward why it's not working. So there's not much that we can do but create an issue and ask. |
Thanks for checking, I think this is good enough. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Left a comment at #3893 (comment) and marking the off-topic comments as such. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Solves #3914
Development notes
IPython
andJupyter
key completions for accessing datasets in the catalog. The solution is based on defining_ipython_key_completions_()
for_FrozenDatasets
class.__
(as for properties) are accepted as well.Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-by
line in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.md
file