Make packaged Kedro project work in interactive environment #4026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
7 tasks
Signed-off-by: Merel Theisen <49397448+merelcht@users.noreply.github.com>
3 tasks
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
noklam
reviewed
Aug 6, 2024
.../test_starter/{{ cookiecutter.repo_name }}/src/{{ cookiecutter.python_package }}/__main__.py
Show resolved
Hide resolved
7 tasks
ElenaKhaustova
approved these changes
Aug 6, 2024
3 tasks
noklam
approved these changes
Aug 8, 2024
|
It's been a long time coming - this is great, great work team |
This was referenced Aug 9, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #3237 and #1807
Updated Databricks docs here: #4067
Follow up on #4012
Note
If/when this PR is accepted, I'll update the starters. For the time being there's a PR with only the find_run_command refactoring changes: kedro-org/kedro-starters#230
Development notes
Similar changes have been proposed before, e.g. #2682 and tried in #3191. Note that there was a bit of muddled communication though around what value to set
standalone_modeto. In many conversations it says settingstandalone_modetoTrue, but that's the default and for an interactive environment like ipython or Databricks it should be set toFalse.How to test
__main__.pyfrom this PR)kedro packagepip install dist/<package>ipythonimport <package>from <package>.__main__ import main()main()To compare this PR to the current status, follow the above steps with the latest released kedro and you'll see that when running
main()inside ipython you'll get anSystemExit: 0.Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-byline in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.mdfile