fix: implement _exists for SharedMemoryDataset
#4121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Felix Scherz <felixwscherz@gmail.com>
Signed-off-by: Felix Scherz <felixwscherz@gmail.com>
Signed-off-by: Felix Scherz <felixwscherz@gmail.com>
felixscherz
force-pushed
the
fix/exists-method-for-shared-memory-dataset
branch
from
a97a74e
to
caa5b1d
Compare
Signed-off-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com>
ankatiyar
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Thank you @felixscherz for this contribution, this fix makes sense to me!
ElenaKhaustova
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Thank you, @felixscherz!
This fix makes sense to me to avoid warning.
Though I'm not sure whether we can rely on the state of SharedMemoryDataset, I think we can merge this fix and later re-consider the purpose of exists for SharedMemoryDataset as well as it's purpose (exists) overall during data catalog redesign work: #3995
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds an
_existsmethod to theSharedMemoryDatasetthat calls the underlyingMemoryDatasetinstead of relying on the inheritedAbstractDataset._existsmethod.This is intended to fix #3703
Development notes
Implemented
_existsforSharedMemoryDatasetand added a test to verify thatSharedMemoryDataset.existsaccurately reflects the state of the underlyingMemoryDataset.Checklist
RELEASE.mdfile