Manually created sitemap.xml for improved control over indexed docs pages #4145

DimedS · 2024-09-05T13:19:30Z

MERGE ONLY BEFORE RELEASE!

Description

Addresses #3741 by manually creating a sitemap.xml file instead of relying on the auto-generated version. This change is intended as a test to determine if it improves our desired outcomes. Depending on the results, we will proceed with the next steps as outlined in this comment.

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

Read the contributing guidelines
Signed off each commit with a Developer Certificate of Origin (DCO)
Opened this PR as a 'Draft Pull Request' if it is work-in-progress
Updated the documentation to reflect the code changes
Added a description of this change in the RELEASE.md file
Added tests to cover my changes
Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

Signed-off-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com>

astrojuanlu

Thanks @DimedS! Left a few comments

docs/source/sitemap.xml

astrojuanlu · 2024-09-06T06:58:40Z

docs/source/sitemap.xml

+<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9" xmlns:xhtml="http://www.w3.org/1999/xhtml">
+  <url>
+    <loc>https://docs.kedro.org/en/stable/</loc>
+    <lastmod>2024-08-01T18:53:11.571849+00:00</lastmod>


I'd suggest we keep this PR open and merge it close to the release so we can have a better estimate of this date

docs/source/sitemap.xml

Signed-off-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com>

astrojuanlu

🤞🏼 and awaiting for the next release...

astrojuanlu · 2024-09-06T14:37:29Z

Thanks a lot @DimedS!

merelcht

I don't know much about sitemaps, but this looks sensible to me 👍

merelcht · 2024-10-08T16:12:39Z

@astrojuanlu Does this need any updates before the release?

astrojuanlu · 2024-10-08T17:13:37Z

docs/source/sitemap.xml

+<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9" xmlns:xhtml="http://www.w3.org/1999/xhtml">
+  <url>
+    <loc>https://docs.kedro.org/en/stable/</loc>
+    <lastmod>2024-09-01T18:53:11.571849+00:00</lastmod>


These dates have to be put here by hand, but we can try to guesstimate them so they are a bit more realistic @merelcht

@lrcouto might be best if you update this and merge right before the release.

merelcht · 2024-10-11T08:39:25Z

Wait was the date updated in the end or not? @lrcouto @ElenaKhaustova @astrojuanlu

astrojuanlu · 2024-10-11T11:56:39Z

More importantly, the sitemap hasn't changed... #3741 (comment)

…ages (#4145) * Load manually created sitemap Signed-off-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com> * Add projects remove lastmod for latest Signed-off-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com> * Add latest for projects Signed-off-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com> --------- Signed-off-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com> Co-authored-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com> Co-authored-by: ElenaKhaustova <157851531+ElenaKhaustova@users.noreply.github.com> Co-authored-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com> Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>

* Update index.md (#4221) Fixed an erroneous link to the Get started with Kedro - Create your first data pipeline with Kedro video. It was accidentally linked to the previous video. Signed-off-by: Greg Vaslowski <7269272+Vaslo@users.noreply.github.com> Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Bump kedro-sphinx-theme from 2024.4.0 to 2024.10.0 (#4216) * Bump kedro-sphinx-theme from 2024.4.0 to 2024.10.0 Bumps [kedro-sphinx-theme](https://github.com/kedro-org/kedro-sphinx-theme) from 2024.4.0 to 2024.10.0. - [Release notes](https://github.com/kedro-org/kedro-sphinx-theme/releases) - [Commits](kedro-org/kedro-sphinx-theme@v2024.4.0...v2024.10.0) --- updated-dependencies: - dependency-name: kedro-sphinx-theme dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * updated to 2024.10.2 * trigger_run * trigger_run --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com> Co-authored-by: rashidakanchwala <rashida_kanchwala@mckinsey.com> Co-authored-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com> Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Replace all instances of "data set" with "dataset" (#4211) Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Manually created sitemap.xml for improved control over indexed docs pages (#4145) * Load manually created sitemap Signed-off-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com> * Add projects remove lastmod for latest Signed-off-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com> * Add latest for projects Signed-off-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com> --------- Signed-off-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com> Co-authored-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com> Co-authored-by: ElenaKhaustova <157851531+ElenaKhaustova@users.noreply.github.com> Co-authored-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com> Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Bump up version to 0.19.9 (#4219) * Bump up version to 0.19.9 Signed-off-by: Laura Couto <laurarccouto@gmail.com> * Add placeholders to release.md Signed-off-by: Laura Couto <laurarccouto@gmail.com> * Update citation.cff release date Signed-off-by: Laura Couto <laurarccouto@gmail.com> --------- Signed-off-by: Laura Couto <laurarccouto@gmail.com> Signed-off-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com> Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * first pass doesn't work yet Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Update ocl tests Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * revert some changes Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Update to use larger config Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Update functions and docstrings Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Add performance tests for DataCatalog Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Update mypy ignore messages (#4228) Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Revise Kedro project structure docs (#4208) * Update project structure docs --------- Signed-off-by: Dmitry Sorokin <dmd40in@gmail.com> Signed-off-by: Dmitry Sorokin <40151847+DimedS@users.noreply.github.com> Co-authored-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Update CLI autocompletion docs with new Click syntax (#4213) * Update CLI autocompletion docs with new Click syntax Updated the autocompletion setup instructions for Bash, Zsh, and Fish shells to reflect the latest Click 8.1 syntax. Changed Fish shell completion script path to ~/.config/fish/completions/kedro.fish for correct placement. Signed-off-by: hyew0nChoi <statistic9935@naver.com> Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Bump import-linter from 2.0 to 2.1 (#4226) Bumps [import-linter](https://github.com/seddonym/import-linter) from 2.0 to 2.1. - [Changelog](https://github.com/seddonym/import-linter/blob/master/CHANGELOG.rst) - [Commits](seddonym/import-linter@v2.0...v2.1) --- updated-dependencies: - dependency-name: import-linter dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Performance test for `OmegaConfigLoader` (#4225) * first pass doesn't work yet Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Update ocl tests Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * revert some changes Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Update to use larger config Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Update functions and docstrings Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * lint Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> --------- Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Add a test for init and fix indent Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Revert "Add a test for init and fix indent" This reverts commit 0dbe3c7. Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Add a test for init and fix indent Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> --------- Signed-off-by: Greg Vaslowski <7269272+Vaslo@users.noreply.github.com> Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> Signed-off-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com> Signed-off-by: Laura Couto <laurarccouto@gmail.com> Signed-off-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com> Signed-off-by: Dmitry Sorokin <dmd40in@gmail.com> Signed-off-by: Dmitry Sorokin <40151847+DimedS@users.noreply.github.com> Signed-off-by: hyew0nChoi <statistic9935@naver.com> Signed-off-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com>

Load manually created sitemap

5ade0c2

Signed-off-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com>

DimedS linked an issue Sep 5, 2024 that may be closed by this pull request

Improve SEO and maintenance of documentation versions #3741

Open

DimedS marked this pull request as ready for review September 5, 2024 13:55

DimedS requested review from yetudada and astrojuanlu as code owners September 5, 2024 13:55

DimedS requested a review from merelcht September 5, 2024 13:55

astrojuanlu reviewed Sep 6, 2024

View reviewed changes

astrojuanlu mentioned this pull request Sep 6, 2024

Improve SEO and maintenance of documentation versions #3741

Open

DmitrySorokinQB added 2 commits September 6, 2024 13:54

Add projects remove lastmod for latest

0daa901

Signed-off-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com>

Add latest for projects

c4014f7

Signed-off-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com>

DimedS requested a review from astrojuanlu September 6, 2024 13:34

astrojuanlu approved these changes Sep 6, 2024

View reviewed changes

merelcht approved these changes Sep 16, 2024

View reviewed changes

merelcht mentioned this pull request Sep 30, 2024

Release kedro #4198

Closed

2 tasks

astrojuanlu reviewed Oct 8, 2024

View reviewed changes

ElenaKhaustova and others added 2 commits October 9, 2024 16:12

Merge branch 'main' into 3741-improve-docs-seo-manually-create-sitemap

0d9c58f

Merge branch 'main' into 3741-improve-docs-seo-manually-create-sitemap

c2a64af

lrcouto merged commit 3a46aba into main Oct 10, 2024
9 checks passed

lrcouto deleted the 3741-improve-docs-seo-manually-create-sitemap branch October 10, 2024 18:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Manually created sitemap.xml for improved control over indexed docs pages #4145

Manually created sitemap.xml for improved control over indexed docs pages #4145

DimedS commented Sep 5, 2024 •

edited

Loading

astrojuanlu left a comment

astrojuanlu Sep 6, 2024

astrojuanlu left a comment

astrojuanlu commented Sep 6, 2024 •

edited

Loading

merelcht left a comment

merelcht commented Oct 8, 2024

astrojuanlu Oct 8, 2024

merelcht Oct 9, 2024

merelcht commented Oct 11, 2024

astrojuanlu commented Oct 11, 2024

Manually created sitemap.xml for improved control over indexed docs pages #4145

Manually created sitemap.xml for improved control over indexed docs pages #4145

Conversation

DimedS commented Sep 5, 2024 • edited Loading

MERGE ONLY BEFORE RELEASE!

Description

Developer Certificate of Origin

Checklist

astrojuanlu left a comment

Choose a reason for hiding this comment

astrojuanlu Sep 6, 2024

Choose a reason for hiding this comment

astrojuanlu left a comment

Choose a reason for hiding this comment

astrojuanlu commented Sep 6, 2024 • edited Loading

merelcht left a comment

Choose a reason for hiding this comment

merelcht commented Oct 8, 2024

astrojuanlu Oct 8, 2024

Choose a reason for hiding this comment

merelcht Oct 9, 2024

Choose a reason for hiding this comment

merelcht commented Oct 11, 2024

astrojuanlu commented Oct 11, 2024

DimedS commented Sep 5, 2024 •

edited

Loading

astrojuanlu commented Sep 6, 2024 •

edited

Loading