-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataCatalog2.0]: Protocol
abstraction for DataCatalog
#4160
Merged
Merged
Changes from all commits
Commits
Show all changes
107 commits
Select commit
Hold shift + click to select a range
a8f4fb3
Added a skeleton for AbstractDataCatalog and KedroDataCatalog
ElenaKhaustova 7d56818
Removed from_config method
ElenaKhaustova 787e121
Merge branch 'main' into refactor-pattern-logic
ElenaKhaustova 0b80f23
Implemented _init_datasets method
ElenaKhaustova 5c727df
Implemented get dataset
ElenaKhaustova 05c9171
Started resolve_patterns implementation
ElenaKhaustova 5c804d6
Implemented resolve_patterns
ElenaKhaustova e9ba5c4
Merge branch 'main' into refactor-pattern-logic
ElenaKhaustova 530f7d6
Fixed credentials resolving
ElenaKhaustova 64be83c
Updated match pattern
ElenaKhaustova c29828a
Implemented add from dict method
ElenaKhaustova 957403a
Updated io __init__
ElenaKhaustova 14908ff
Added list method
ElenaKhaustova c5e925b
Implemented _validate_missing_keys
ElenaKhaustova b9a92b0
Added datasets access logic
ElenaKhaustova 2cb794f
Merge branch 'main' into refactor-pattern-logic
ElenaKhaustova 2f32593
Added __contains__ and comments on lazy loading
ElenaKhaustova d1ea64e
Renamed dataset_name to ds_name
ElenaKhaustova fb89fca
Updated some docstrings
ElenaKhaustova 4486939
Merge branch 'main' into refactor-pattern-logic
ElenaKhaustova c667645
Fixed _update_ds_configs
ElenaKhaustova be8e929
Fixed _init_datasets
ElenaKhaustova ec7ac39
Implemented add_runtime_patterns
ElenaKhaustova 8e23450
Fixed runtime patterns usage
ElenaKhaustova 529e61a
Merge branch 'main' into refactor-pattern-logic
ElenaKhaustova e4cb21c
Merge branch 'main' into refactor-pattern-logic
ElenaKhaustova 50bc816
Moved pattern logic out of data catalog, implemented KedroDataCatalog
ElenaKhaustova 6dfbcb0
Merge branch 'main' into 4110-move-pattern-resolution-logic
ElenaKhaustova 9346f08
KedroDataCatalog updates
ElenaKhaustova 9568e29
Added property to return config
ElenaKhaustova 86efdfe
Merge branch 'main' into 4110-move-pattern-resolution-logic
ElenaKhaustova 5e27660
Added list patterns method
ElenaKhaustova 72b11d0
Renamed and moved ConfigResolver
ElenaKhaustova f0a4090
Renamed ConfigResolver
ElenaKhaustova a4da52a
Merge branch 'main' into 4110-move-pattern-resolution-logic
ElenaKhaustova 7d6227f
Cleaned KedroDataCatalog
ElenaKhaustova 4092291
Cleaned up DataCatalogConfigResolver
ElenaKhaustova 63e47f9
Docs build fix attempt
ElenaKhaustova 68f6527
Removed KedroDataCatalog
ElenaKhaustova 2ac4a2f
Updated from_config method
ElenaKhaustova cb5879d
Updated constructor and add methods
ElenaKhaustova 9038e96
Updated _get_dataset method
ElenaKhaustova cc89565
Updated __contains__
ElenaKhaustova 59b6764
Updated __eq__ and shallow_copy
ElenaKhaustova 4f5a3fb
Added __iter__ and __getitem__
ElenaKhaustova 12ed6f2
Removed unused imports
ElenaKhaustova a106cec
Added TODO
ElenaKhaustova 6df04f7
Updated runner.run()
ElenaKhaustova 8566e27
Updated session
ElenaKhaustova 2dcea33
Added confil_resolver property
ElenaKhaustova a46597f
Updated catalog list command
ElenaKhaustova 3787545
Updated catalog create command
ElenaKhaustova 68d612d
Updated catalog rank command
ElenaKhaustova af5bee9
Updated catalog resolve command
ElenaKhaustova acc4d6e
Merge branch 'main' into 4110-move-pattern-resolution-logic
ElenaKhaustova e67ff0f
Remove some methods
ElenaKhaustova 7b3afa2
Removed ds configs from catalog
ElenaKhaustova 658a759
Fixed lint
ElenaKhaustova 7be2a8e
Fixed typo
ElenaKhaustova 09f3f26
Merge branch 'main' into 4110-move-pattern-resolution-logic
ElenaKhaustova 9e43a9a
Added module docstring
ElenaKhaustova 25b6501
Removed None from Pattern type
ElenaKhaustova 3a646de
Fixed docs failing to find class reference
ElenaKhaustova 5e5df4a
Fixed docs failing to find class reference
ElenaKhaustova aa59a35
Updated Patterns type
ElenaKhaustova c7efa3e
Fix tests (#4149)
ankatiyar 023ffc6
Returned constants to avoid breaking changes
ElenaKhaustova 585b44f
Minor fix
ElenaKhaustova e447078
Updated test_sorting_order_with_other_dataset_through_extra_pattern
ElenaKhaustova beb0165
Merge branch 'main' into 4110-move-pattern-resolution-logic
ElenaKhaustova 975e968
Removed odd properties
ElenaKhaustova 11d782c
Updated tests
ElenaKhaustova e4abd23
Removed None from _fetch_credentials input
ElenaKhaustova 6433dd8
Renamed DataCatalogConfigResolver to CatalogConfigResolver
ElenaKhaustova 355576f
Renamed _init_configs to _resolve_config_credentials
ElenaKhaustova 39d9ff6
Moved functions to the class
ElenaKhaustova 659c9da
Refactored resolve_dataset_pattern
ElenaKhaustova 840b32a
Fixed refactored part
ElenaKhaustova 77f551c
Changed the order of arguments for DataCatalog constructor
ElenaKhaustova 6e079a1
Replaced __getitem__ with .get()
ElenaKhaustova 1f7e5f8
Updated catalog commands
ElenaKhaustova 80f0e3d
Moved warm up block outside of the try block
ElenaKhaustova 017cda3
Fixed linter
ElenaKhaustova cab6f06
Removed odd copying
ElenaKhaustova 8f604d1
Updated release notes
ElenaKhaustova 9a4db18
Returned DatasetError
ElenaKhaustova 0a6946a
Added _dataset_patterns and _default_pattern to _config_resolver to a…
ElenaKhaustova fee7bd6
Made resolve_dataset_pattern return just dict
ElenaKhaustova f5a7992
Fixed linter
ElenaKhaustova 1c981f3
Added Catalogprotocol draft
ElenaKhaustova 6128be7
Implemented CatalogProtocol
ElenaKhaustova 8c91d0e
Updated types
ElenaKhaustova 18d2ba0
Fixed linter
ElenaKhaustova d48c6d3
Added _ImplementsCatalogProtocolValidator
ElenaKhaustova 45ce6bc
Updated docstrings
ElenaKhaustova 6ca972f
Fixed tests
ElenaKhaustova fdce5ea
Fixed docs
ElenaKhaustova 3029963
Excluded Potocol from coverage
ElenaKhaustova 0150a21
Merge branch 'main' into 4138-catalog-protocol
ElenaKhaustova 0833a84
Fixed docs
ElenaKhaustova 0ec1f23
Removed reference to DataCatalog in docstrings
ElenaKhaustova 741b682
Removed add_all from protocol
ElenaKhaustova 78feb51
Updated docstrings
ElenaKhaustova 6bf912c
Updated docstrings
ElenaKhaustova c9c7c9a
Fixed docstrings
ElenaKhaustova c66df33
Merge branch 'main' into 4138-catalog-protocol
ElenaKhaustova 4d92c33
Updated RELEASE.md
ElenaKhaustova File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Is this how type hint supposed to be done with Protocol? I roughly understand how Protocol works like traits/interface but I haven't seen much in a real codebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, cause this is type in the end, see examples here: https://peps.python.org/pep-0544/#protocol-members