-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pytest-cov requirement from ~=3.0 to >=3,<7 #4297
Conversation
Updates the requirements on [pytest-cov](https://github.com/pytest-dev/pytest-cov) to permit the latest version. - [Changelog](https://github.com/pytest-dev/pytest-cov/blob/master/CHANGELOG.rst) - [Commits](pytest-dev/pytest-cov@v3.0.0...v6.0.0) --- updated-dependencies: - dependency-name: pytest-cov dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Should we continue our practice of closing these PRs due to failing unit tests (e.g., this one)? Or, given that our current |
Good question! Considering we're quite behind the latest version I would vote for updating the code to work with the latest pytest-cov version. |
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
The failures were due to the removal of multiprocessing support in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @ankatiyar!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's really great that you found a solution, @ankatiyar ! I see that we have pytest-cov~=3.0
in many places in our code base, including starters. Should we create an follow up issue for change them also?
@DimedS let me try to bump those up in our other repos too |
Updates the requirements on pytest-cov to permit the latest version.
Changelog
Sourced from pytest-cov's changelog.
... (truncated)
Commits
9540437
Bump version: 5.0.0 → 6.0.09f81754
Further trim down envs and drop Python 3.8.b12b5ec
Update conf.23f4b27
Update changelog.291a04f
Bump test deps and trim config.08f1101
Add--cov-precision
option. Close #655.76fe2a7
Move the warnings/errors in a place that doesn't import anything.a9ea7b7
Implement error/warning for the bad dynamic_context being set in config.c299e01
Add explicit suffixing to make it easier to see the identify the sources/usag...c87e546
Add reproducer for weird xdist dynamic_context interaction. Ref #604.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)