Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more translations #2244

Merged
merged 3 commits into from
Jun 15, 2024
Merged

Fix more translations #2244

merged 3 commits into from
Jun 15, 2024

Conversation

varjolintu
Copy link
Member

Changes:

  • Adds button titles to options page and popup.
  • Modifies the names to be identical in every place.
  • Removes obsolete alt properties from div icons.

Fixes #2241.
Fixes #2242

@varjolintu varjolintu added this to the 1.9.1 milestone Jun 14, 2024
@varjolintu varjolintu requested a review from droidmonkey June 14, 2024 05:23
@varjolintu varjolintu changed the title Fix/more translations Fix more translations Jun 14, 2024
keepassxc-browser/_locales/en/messages.json Outdated Show resolved Hide resolved
@varjolintu varjolintu merged commit 2ef5936 into develop Jun 15, 2024
@varjolintu varjolintu deleted the fix/more_translations branch June 15, 2024 05:46
@Chealer
Copy link

Chealer commented Jun 15, 2024

Changes:

* Adds button titles to options page and popup.

* Modifies the names to be identical in every place.

* Removes obsolete `alt` properties from `div` icons.

Fixes #2241. Fixes #2242

Thank you @varjolintu
However:

  1. This does not fix Options: Unclear Connect button in Connected Databases tab #2241.
  2. The title is not appropriate for the above changes.
  3. The alt attribute is not obsolete. It merely does not apply to div elements.

@varjolintu
Copy link
Member Author

@Chealer #2241 (comment)

@keepassxreboot keepassxreboot locked and limited conversation to collaborators Jun 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants