Hide window when performing entry auto-type on macOS #2969
Conversation
droidmonkey
force-pushed
the
hotfix/macos-autotype
branch
from
4da3e9a
to
d82eaa0
Compare
|
Whoops, missed the actual function call. |
* Instead of choosing the last active window, always hide the current window (ie, KeePassXC) * Fixes #2883
droidmonkey
force-pushed
the
hotfix/macos-autotype
branch
from
d82eaa0
to
17a13e3
Compare
- Fix database deletion when using unsafe saves to a different file system [#2889] - Fix opening databases with legacy key files that contain '/' [#2872] - Fix opening database files from the command line [#2919] - Fix crash when editing master key [#2836] - Fix multiple issues with apply button behavior [#2947] - Fix issues on application startup (tab order, --pw-stdin, etc.) [#2830] - Fix building without WITH_XC_KEESHARE - Fix reference entry coloring on macOS dark mode [#2984] - Hide window when performing entry auto-type on macOS [#2969] - Improve UX of update checker; reduce checks to every 7 days [#2968] - KeeShare improvements [#2946, #2978, #2824] - Re-enable Ctrl+C to copy password from search box [#2947] - Add KeePassXC-Browser integration for Brave browser [#2933] - SSH Agent: Re-Add keys on database unlock [#2982] - SSH Agent: Only remove keys on app exit if they are removed on lock [#2985] - CLI: Add --no-password option [#2708] - CLI: Improve database extraction to XML [#2698] - CLI: Don't call mandb on build [#2774] - CLI: Add debug info [#2714] - Improve support for Snap theming [#2832] - Add support for building on Haiku OS [#2859] - Ctrl+PgDn now goes to the next tab and Ctrl+PgUp to the previous - Fix compiling on GCC 5 / Xenial [#2990] - Add .gitrev output to tarball for third-party builds [#2970] - Add WITH_XC_UPDATECHECK compile flag to toggle the update checker [#2968]
|
Seems like this change breaks Auto-Typing in the "Tunnelblick: Login Required" dialog. Instead of selecting Tunnelblick login dialog, it seems to select the last window that is also reachable with CMD-Tab, and happily pastes login data there. Unfortunately Tunnelblick is not reachable like this, since it seems to use a different window / dialog type. Even the Tunnelblick configuration window does not have a title bar. Also, Tunnelblick's dialog title is not selectable in the Autotype/Window Associations configuration page in KeepassXC. It may be arguable if that is an issue in either KeepassXC or Tunnelblick (not providing a main window to change to). But I wonder if that could be solved in KeepassXC again, since it worked before 2.4.1. |
|
That is unfortunate. Switching to the last selected window is the behavior on every other platform (fwiw). I would argue that Tunnelblick needs to conform to OS window standards |
Type of change
Description and Context
Testing strategy
Tested on macOS
Checklist:
-DWITH_ASAN=ON. [REQUIRED]