-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FdoSecrets: Improve client executable path handling #6915
Conversation
11c3463
to
f01fba0
Compare
The windows CI failure is unrelated. And I have no clue why the test fails when building AppImage on GCC in Release mode... probably some random error. Other than that, this is ready :) |
This is some seriously good stuff |
… and clients list
f01fba0
to
402db68
Compare
Codecov Report
@@ Coverage Diff @@
## develop #6915 +/- ##
===========================================
- Coverage 63.78% 63.68% -0.10%
===========================================
Files 330 330
Lines 41430 41576 +146
===========================================
+ Hits 26423 26475 +52
- Misses 15007 15101 +94
Continue to review full report at Codecov.
|
After a busy summer, I'm back with some more time to contribute 😎
This PR improves the overall handling of FdoSecrets showing client executable paths to the user. It does the following
More about the auth dialog: someone in previous discussions (sorry I didn't remember exactly where) mentioned showing the process hierarchy. I liked the idea and it looks indeed cool. But I'm not sure if the function belongs to KPXC. Maybe it's better to just let the user use whatever tool already available (e.g.
pstree
) rather than duplicating the functionality.Fixes #6459
Screenshots
Client list
Valid exe path
Invalid exe path
Notifications
Auth dialog
When the path is valid, default to collapsed mode
When the path is invalid, default to expanded mode with a warning
Testing strategy
Type of change