Fix TestGui::testDatabaseSettings open tab missing #9162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test at TestGui::testDatabaseSettings for changing transform rounds at encryption settings tab inside the security category is done in memory as the opening the tab was missing. This commit add instuctions for going into the encryption widget before making the changes.
droidmonkey
approved these changes
Feb 24, 2023
pull bot
pushed a commit
to tigerwill90/keepassxc
that referenced
this pull request
Feb 25, 2023
Co-authored-by: jNullj <jNullj@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test at TestGui::testDatabaseSettings for changing transform rounds at encryption settings tab inside the security category is done in memory as the opening the tab was missing.
This commit add instuctions for going into the encryption widget before making the changes.
This issue is mentioned here and was found as part of pull request #9100 .
Screenshots
Testing strategy
You can duplicate the issue by running TestGui::testDatabaseSettings() line by line in debug and you will notice everything is done in memory as the gui does not go into the right area.
To test this fix you could just do the same with this branch, i also tested format and coverage after making this fix.
Type of change