Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIARDDK support #625

Merged
merged 1 commit into from
Nov 6, 2024
Merged

SIARDDK support #625

merged 1 commit into from
Nov 6, 2024

Conversation

AntonioG70
Copy link
Contributor

No description provided.

@AntonioG70 AntonioG70 requested a review from 006627 September 18, 2024 16:11
@AntonioG70 AntonioG70 force-pushed the alindo-dev-virtualTable branch from 32db6f6 to db64a95 Compare September 19, 2024 08:40
@AntonioG70 AntonioG70 force-pushed the alindo-dev-virtualTable branch from 627f938 to 71a141e Compare October 15, 2024 09:18
006627
006627 requested changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@006627 006627 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of code is repeated due to the SIARD DK version separation, please review and apply best practices to ensure good code quality, I will finish reviewing this PR when you have these changes ready.

dbptk-core/src/test/java/com/databasepreservation/siarddk/SIARDDKTestUtil.java Show resolved Hide resolved
dbptk-core/src/test/java/com/databasepreservation/testing/integration/siard/SiardDKTest.java Outdated Show resolved Hide resolved
dbptk-core/src/test/java/com/databasepreservation/testing/integration/siard/SiardTest.java Outdated Show resolved Hide resolved
dbptk-core/src/test/java/com/databasepreservation/testing/integration/siard/SiardTest.java Outdated Show resolved Hide resolved
dbptk-core/src/test/resources/siarddk/AVID.SA.18001.1/Indices/fileIndex.xml Outdated Show resolved Hide resolved
...java/com/databasepreservation/modules/siard/in/path/ArchiveFileIndexInputStreamStrategy.java Outdated Show resolved Hide resolved
.../main/java/com/databasepreservation/modules/siard/in/path/SIARDDK1007PathImportStrategy.java Outdated Show resolved Hide resolved
...c/main/java/com/databasepreservation/modules/siard/in/path/SIARDDK128PathImportStrategy.java Outdated Show resolved Hide resolved
...ava/com/databasepreservation/modules/siard/out/content/SIARDDK1007ContentExportStrategy.java Outdated Show resolved Hide resolved
...m/databasepreservation/modules/siard/out/metadata/SIARDDK1007ContextDocumentationWriter.java Outdated Show resolved Hide resolved
@AntonioG70 AntonioG70 force-pushed the alindo-dev-virtualTable branch 2 times, most recently from f2a7ed5 to a1747ec Compare October 25, 2024 09:24
@AntonioG70 AntonioG70 force-pushed the alindo-dev-virtualTable branch from 1a678f5 to 30d3019 Compare October 30, 2024 17:33
@AntonioG70 AntonioG70 mentioned this pull request Oct 30, 2024
Closed
@AntonioG70 AntonioG70 force-pushed the alindo-dev-virtualTable branch from 30d3019 to 117d673 Compare October 31, 2024 09:24
@AntonioG70 AntonioG70 requested a review from 006627 October 31, 2024 09:44
@AntonioG70 AntonioG70 force-pushed the alindo-dev-virtualTable branch from 117d673 to 34a599a Compare October 31, 2024 16:10
@006627 006627 merged commit 88c8038 into development Nov 6, 2024
2 checks passed
006627 added a commit that referenced this pull request Nov 28, 2024
@006627
Merge pull request #625 from keeps/alindo-dev-virtualTable
daa63ca 
SIARDDK support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@006627 006627 006627 approved these changes

Assignees

@006627 006627

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AntonioG70 @006627