Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save / get search results to / from storage #9

Closed
0is1 opened this issue Jul 22, 2016 · 1 comment
Closed

Save / get search results to / from storage #9

0is1 opened this issue Jul 22, 2016 · 1 comment
Assignees
@0is1
Labels
enhancement

Comments

@0is1
Copy link
Member

0is1 commented Jul 22, 2016

Now every search fires new API search-request. There's already setData to latest search query data https://github.com/kehittamo/oluttamo-browser-extension/blob/master/app/scripts/lib/setData.js#L8-L10

We should improve that and save for example latest 50 search results to storage and get data if query string is found from storage data.
@0is1 0is1 self-assigned this Aug 18, 2016
0is1 added a commit that referenced this issue Aug 18, 2016
@0is1
Rename getCurrentSearchString.js to getData.js, promisify things, che…
7776399 
…ck if search query data is found from storage #9
@0is1
Copy link
Member Author

0is1 commented Aug 18, 2016

Let's close this but we need to think about clearing storage data with some logic later on...

@0is1 0is1 closed this as completed Aug 18, 2016
@0is1 0is1 mentioned this issue Aug 18, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0is1 0is1

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@0is1