Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add image default label to nodes #270

Merged
merged 4 commits into from
Apr 7, 2021

Conversation

eytan-avisror
Copy link
Collaborator

Signed-off-by: Eytan Avisror eytan_avisror@intuit.com

Fixes #262

Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com>
@eytan-avisror eytan-avisror requested review from a team as code owners April 5, 2021 01:25
@codecov
Copy link

codecov bot commented Apr 5, 2021

Codecov Report

Merging #270 (b480946) into master (6577998) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #270   +/-   ##
=======================================
  Coverage   87.81%   87.82%           
=======================================
  Files          17       17           
  Lines        2266     2267    +1     
=======================================
+ Hits         1990     1991    +1     
  Misses        173      173           
  Partials      103      103           
Impacted Files Coverage Δ
controllers/provisioners/eks/eks.go 84.21% <ø> (ø)
controllers/provisioners/eks/helpers.go 91.39% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6577998...b480946. Read the comment docs.

@eytan-avisror eytan-avisror merged commit c0eb25d into keikoproj:master Apr 7, 2021
@eytan-avisror eytan-avisror mentioned this pull request Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add node label referencing the AMI
2 participants