Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: conditional default values #273

Merged
merged 5 commits into from
Apr 18, 2021
Merged

Conversation

backjo
Copy link
Collaborator

@backjo backjo commented Apr 15, 2021

Closes #189

@backjo backjo added the WIP label Apr 15, 2021
@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #273 (f72f750) into master (fac0608) will increase coverage by 0.15%.
The diff coverage is 87.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #273      +/-   ##
==========================================
+ Coverage   87.89%   88.05%   +0.15%     
==========================================
  Files          17       17              
  Lines        2272     2319      +47     
==========================================
+ Hits         1997     2042      +45     
- Misses        172      173       +1     
- Partials      103      104       +1     
Impacted Files Coverage Δ
controllers/provisioners/config.go 78.34% <87.75%> (+7.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fac0608...f72f750. Read the comment docs.

@backjo backjo force-pushed the feature/conditional-defaults branch 2 times, most recently from a37f1fa to a54db47 Compare April 15, 2021 06:32
Signed-off-by: Jonah Back <jonah@jonahback.com>
@backjo backjo force-pushed the feature/conditional-defaults branch from a54db47 to 79c0b5b Compare April 15, 2021 06:43
@eytan-avisror
Copy link
Collaborator

eytan-avisror commented Apr 15, 2021

Very cool. had some questions when you get the chance.. We may need to think about the edge cases of conflicts in default between multiple matching conditionals

Signed-off-by: Jonah Back <jonah@jonahback.com>
docs/EKS.md Outdated Show resolved Hide resolved
docs/EKS.md Outdated Show resolved Hide resolved
@backjo backjo marked this pull request as ready for review April 18, 2021 01:41
@backjo backjo requested review from a team as code owners April 18, 2021 01:41
Signed-off-by: Jonah Back <jonah@jonahback.com>
@backjo backjo changed the title (WIP) feat: initial conditional default work feat: initial conditional default work Apr 18, 2021
@backjo backjo removed the WIP label Apr 18, 2021
Copy link
Collaborator

@eytan-avisror eytan-avisror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@eytan-avisror eytan-avisror changed the title feat: initial conditional default work feat: conditional default values Apr 18, 2021
@eytan-avisror eytan-avisror merged commit bb272e3 into master Apr 18, 2021
@eytan-avisror eytan-avisror mentioned this pull request Apr 28, 2021
@tekenstam tekenstam deleted the feature/conditional-defaults branch September 18, 2023 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multiple 'default' groups
2 participants