-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: conditional default values #273
Conversation
Codecov Report
@@ Coverage Diff @@
## master #273 +/- ##
==========================================
+ Coverage 87.89% 88.05% +0.15%
==========================================
Files 17 17
Lines 2272 2319 +47
==========================================
+ Hits 1997 2042 +45
- Misses 172 173 +1
- Partials 103 104 +1
Continue to review full report at Codecov.
|
a37f1fa
to
a54db47
Compare
Signed-off-by: Jonah Back <jonah@jonahback.com>
a54db47
to
79c0b5b
Compare
Very cool. had some questions when you get the chance.. We may need to think about the edge cases of conflicts in default between multiple matching conditionals |
Signed-off-by: Jonah Back <jonah@jonahback.com>
Signed-off-by: Jonah Back <jonah@jonahback.com>
Signed-off-by: Jonah Back <jonah@jonahback.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
Closes #189