feat: prometheus metrics integration #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
April 14, 2021 15:35
Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com>
Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com>
Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com>
Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com>
Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com>
Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com>
added 3 commits
April 16, 2021 11:57
Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com>
Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com>
Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com>
eytan-avisror
changed the title
Codecov Report
@@ Coverage Diff @@
## master #274 +/- ##
==========================================
+ Coverage 87.82% 87.89% +0.07%
==========================================
Files 17 17
Lines 2267 2272 +5
==========================================
+ Hits 1991 1997 +6
+ Misses 173 172 -1
Partials 103 103
Continue to review full report at Codecov.
|
|
Some examples on dashing the added metrics |
kevdowney
reviewed
Apr 16, 2021
| } | ||
|
|
||
| func (c *MetricsCollector) SetInstanceGroup(instanceGroup, state string) { | ||
| externalStates := []string{"ReconcileModifying", "InitUpgrade", "Deleting", "Ready", "Error"} |
There was a problem hiding this comment.
Yes, in v1alpha1 - this would be a cyclic dependency if we use them though
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #238
This adds a basic prometheus collector integration to expose metrics.