fix: add locking to map access

[eytan-avisror]

Signed-off-by: Eytan Avisror eytan_avisror@intuit.com
Fixes #278

This adds a read lock/unlock when accessing Namespaces map

[codecov]

Codecov Report

Merging #279 (5548cae) into master (088d011) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #279   +/-   ##
=======================================
  Coverage   70.23%   70.23%           
=======================================
  Files          19       19           
  Lines        2970     2970           
=======================================
  Hits         2086     2086           
  Misses        755      755           
  Partials      129      129           

Impacted Files	Coverage Δ
controllers/provisioners/config.go	78.34% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 088d011...5548cae. Read the comment docs.

[backjo]

Is this missing the changes needed in reconcilers.go?

[eytan-avisror]

Is this missing the changes needed in reconcilers.go?

Nope, the write part already locks:

instance-manager/controllers/reconcilers.go

Lines 125 to 138 in 165312e

	func (r *InstanceGroupReconciler) namespaceReconciler(obj client.Object) []ctrl.Request {
	var (
	name = obj.GetName()
	)
	ctrl.Log.Info("namespace watch event", "object", name)
	namespacedName := types.NamespacedName{
	Namespace: "",
	Name: name,
	}
	r.NamespacesLock.Lock()
	defer r.NamespacesLock.Unlock()

[backjo]

Ah, gotcha. I'm blind :P

Anywho - noticed a compilation failure on local - filed #280 to fix our checks.

vet: ./main.go:153:27: cannot use &(sync.Mutex literal) (value of type *sync.Mutex) as *sync.RWMutex value in struct literal

[eytan-avisror]

Ah, gotcha. I'm blind :P

Anywho - noticed a compilation failure on local - filed #280 to fix our checks.

vet: ./main.go:153:27: cannot use &(sync.Mutex literal) (value of type *sync.Mutex) as *sync.RWMutex value in struct literal

Hmm, looks like we are bypassing make test by calling go test directly which doesnt run vet