-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: run build on unit test task #281
Conversation
.github/workflows/unit-test.yml
Outdated
- name: Build | ||
run: | | ||
make go | ||
|
||
- name: Test | ||
run: | | ||
go test -v ./controllers/... -coverprofile coverage.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we might want to change this to make test
while we are doing this
Signed-off-by: Jonah Back <jonah@jonahback.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Codecov Report
@@ Coverage Diff @@
## master #281 +/- ##
=========================================
Coverage ? 70.23%
=========================================
Files ? 19
Lines ? 2970
Branches ? 0
=========================================
Hits ? 2086
Misses ? 755
Partials ? 129 Continue to review full report at Codecov.
|
Signed-off-by: Jonah Back jonah@jonahback.com