fix: only set restricted field to default value if none of the conditionals set it

[backjo]

fixes #283

Signed-off-by: Jonah Back jonah@jonahback.com

[codecov]

Codecov Report

Merging #284 (eb88d4f) into master (002bf72) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #284   +/-   ##
=======================================
  Coverage   70.23%   70.23%           
=======================================
  Files          19       19           
  Lines        2970     2970           
=======================================
  Hits         2086     2086           
  Misses        755      755           
  Partials      129      129           

Impacted Files	Coverage Δ
controllers/provisioners/config.go	78.34% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 002bf72...eb88d4f. Read the comment docs.

[eytan-avisror]

So this would set all conditional with the first match?
Would we need a hotfix btw?

[backjo]

Worse, actually. It would only set fields that were in the last match, since setField was getting reset for every applicable conditional. If the field wasn't set by the last conditional, it would override with the default value, if one existed.

[backjo]

Yeah, a patch release would probably make sense.